Add new license bsd-3-clause-cryptogams for the CRYPTOGAMS license - #5288
Open
MGpromax wants to merge 2 commits into
Open
Add new license bsd-3-clause-cryptogams for the CRYPTOGAMS license#5288MGpromax wants to merge 2 commits into
MGpromax wants to merge 2 commits into
Conversation
Add new license bsd-3-clause-cryptogams, requested in issue aboutcode-org#5253. The license text now detects as bsd-3-clause-cryptogams with score 100; it previously matched a spurious combination of unrelated licenses. Reference: aboutcode-org#5253 Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
The CRYPTOGAMS fossology test files now detect as the new dedicated bsd-3-clause-cryptogams license instead of the bsd-new OR gpl-1.0-plus approximation. Adding the new license text to the index also perturbs two unrelated detections (manual-bsdstyle gains a bsd-source-code match; the bilingual MulanPSL-1.0.t1 file now matches three mulanpsl-1.0-en regions instead of one mulanpsl-1.0) - regenerated with SCANCODE_REGEN_TEST_FIXTURES and flagged in the PR for review. Signed-off-by: Manoj Gowda <manojgowdabs18@gmail.com>
Author
|
CI update: the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5253
Adds
bsd-3-clause-cryptogamsfor the CRYPTOGAMS license (the BSD-3-Clause variant used by Andy Polyakov's CRYPTOGAMS cryptographic assembly modules, with an alternative clause allowing distribution under the GPL instead), using the name suggested in the issue. Text from the LICENSE file of https://github.com/dot-asm/cryptogams; SPDX has no identifier for it (checked the current license list), sospdx_license_key: LicenseRef-scancode-bsd-3-clause-cryptogams.category: Permissive, with the GPL-alternative clause recorded innotes.Detection before this change: the text matched
bsd-new OR gpl-1.0-plus, which approximates the semantics but loses the CRYPTOGAMS identity that tools like ORT need to track these files precisely. It now detects asbsd-3-clause-cryptogamswith score 100.Validation (same for all six license additions from this batch):
scancode-reindex-licensesruns clean--test-suite=validate tests/licensedcode/test_detection_validate.py), with ignorables generated by the test regen tooling rather than by handpytest tests/licensedcode/test_license_models.pypasses locallyTasks